lkml.org 
[lkml]   [2019]   [Apr]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH -next] acpi/hmat: fix an uninitialized memory_target
    Date
    The commit 665ac7e92757 ("acpi/hmat: Register processor domain to its
    memory") introduced an uninitialized "struct memory_target" that could
    cause an incorrect branching.

    drivers/acpi/hmat/hmat.c:385:6: warning: variable 'target' is used
    uninitialized whenever 'if' condition is false
    [-Wsometimes-uninitialized]
    if (p->flags & ACPI_HMAT_MEMORY_PD_VALID) {
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    drivers/acpi/hmat/hmat.c:392:6: note: uninitialized use occurs here
    if (target && p->flags & ACPI_HMAT_PROCESSOR_PD_VALID) {
    ^~~~~~
    drivers/acpi/hmat/hmat.c:385:2: note: remove the 'if' if its condition
    is always true
    if (p->flags & ACPI_HMAT_MEMORY_PD_VALID) {
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    drivers/acpi/hmat/hmat.c:369:30: note: initialize the variable 'target'
    to silence this warning
    struct memory_target *target;
    ^
    = NULL

    Signed-off-by: Qian Cai <cai@lca.pw>
    ---
    drivers/acpi/hmat/hmat.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/acpi/hmat/hmat.c b/drivers/acpi/hmat/hmat.c
    index c9b8abcf012c..6653dba3b377 100644
    --- a/drivers/acpi/hmat/hmat.c
    +++ b/drivers/acpi/hmat/hmat.c
    @@ -366,7 +366,7 @@ static int __init hmat_parse_proximity_domain(union acpi_subtable_headers *heade
    const unsigned long end)
    {
    struct acpi_hmat_proximity_domain *p = (void *)header;
    - struct memory_target *target;
    + struct memory_target *target = NULL;

    if (p->header.length != sizeof(*p)) {
    pr_notice("HMAT: Unexpected address range header length: %d\n",
    --
    2.17.2 (Apple Git-113)
    \
     
     \ /
      Last update: 2019-04-07 03:14    [W:4.154 / U:0.468 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site