Messages in this thread | | | Subject | Re: [PATCH] xsysace: Fix error handling in ace_setup | From | Guenter Roeck <> | Date | Sat, 6 Apr 2019 12:34:23 -0700 |
| |
On 4/5/19 4:06 PM, Jens Axboe wrote: > On 4/5/19 4:44 PM, Guenter Roeck wrote: >> Hi, >> >> On Tue, Feb 19, 2019 at 08:49:56AM -0800, Guenter Roeck wrote: >>> If xace hardware reports a bad version number, the error handling code >>> in ace_setup() calls put_disk(), followed by queue cleanup. However, since >>> the disk data structure has the queue pointer set, put_disk() also >>> cleans and releases the queue. This results in blk_cleanup_queue() >>> accessing an already released data structure, which in turn may result >>> in a crash such as the following. >>> >> >> This crash is now quite persistent in mainline. The fix didn't make it. >> Should I stop testing virtex-ml507 with qemu ? > > I've applied the fix now. > > But given Michal's comments, should we kill the driver for 5.2? >
If the driver is no longer used or maintained, removing it would indeed make sense.
Guenter
| |