lkml.org 
[lkml]   [2019]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86/reboot: Use efi reboot for Acer TravelMate X514-51T
On Mon, 1 Apr 2019, Jian-Hong Pan wrote:
> +/*
> + * Some machines require the "reboot=e" commandline options
> + */
> +static int __init set_efi_reboot(const struct dmi_system_id *d)
> +{
> + if (reboot_type != BOOT_EFI) {
> + reboot_type = BOOT_EFI;

So if EFI is disabled in the kernel this will fall through to BOOT_BIOS. Is
that intended behaviour?

> + pr_info("%s series board detected. Selecting %s-method for reboot.\n",
> + d->ident, "EFI");

Is thee a reason not to write "EFI" in the string itself?

Thanks,

tglx

\
 
 \ /
  Last update: 2019-04-05 23:14    [W:0.045 / U:24.828 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site