lkml.org 
[lkml]   [2019]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v11 04/27] clocksource: Add a new timer-ingenic driver
On Thu, 28 Mar 2019, Paul Cercueil wrote:

> This driver handles the TCU (Timer Counter Unit) present on the Ingenic
> JZ47xx SoCs, and provides the kernel with a system timer, and optionally
> with a clocksource and a sched_clock.
>
> It also provides clocks and interrupt handling to client drivers.

Why on earth has a timer driver clock and interrupt chip drivers in it?

We have different subsystems for good reasons. Please split this apart and
add the support to the appropriate subsystems, clocksource, irqchip, clk

Thanks,

tglx




\
 
 \ /
  Last update: 2019-04-05 22:45    [W:0.106 / U:53.256 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site