lkml.org 
[lkml]   [2019]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v3 11/13] thermal: qoriq: Do not report invalid temperature reading
On Thu, Apr 4, 2019 at 2:05 AM Daniel Lezcano <daniel.lezcano@linaro.org> wrote:
>
> On 01/04/2019 06:14, Andrey Smirnov wrote:
> > Before returning measured temperature data to upper layer we need to
> > make sure that the reading was marked as "valid" to avoid reporting
> > bogus data.
>
> Is it possible to add a comment above the read_poll to describe the
> layout of the register ? That will help to understand the valid bit.
>

Sure, will do.

> Is the valid bit reset after reading the value?
>

It works a bit differently. Here's the description form the datasheet:

Valid measured temperature.
0 Not valid. Temperature out of sensor range or first
measurement still pending.
1 Valid.

Thanks,
Andrey Smirnov

\
 
 \ /
  Last update: 2019-04-05 20:31    [W:0.065 / U:4.156 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site