lkml.org 
[lkml]   [2019]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] block: remove CONFIG_LBDAF
From
Date
On 4/5/19 10:08 AM, Christoph Hellwig wrote:
> Currently support for 64-bit sector_t and blkcnt_t is optional on 32-bit
> architectures. These types are required to support block device and/or
> file sizes larger than 2 TiB, and have generally defaulted to on for
> a long time. Enabling the option only increases the i386 tinyconfig
> size by 145 bytes, and many data structures already always use
> 64-bit values for their in-core and on-disk data structures anyway,
> so there should not be a large change in dynamic memory usage either.
>
> Dropping this option removes a somewhat weird non-default config that
> has cause various bugs or compiler warnings when actually used.

I'm greatly in favor of this - but can we drop the defconfig changes?
Not strictly needed, it's not like they will cause issues with the
symbol still being there.

--
Jens Axboe

\
 
 \ /
  Last update: 2019-04-05 20:01    [W:0.037 / U:0.800 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site