lkml.org 
[lkml]   [2019]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2 1/5] arm64: allwinner: h6: orangepi: Add PIO regulators
Hi,

On Fri, 5 Apr 2019 at 17:08, Maxime Ripard <maxime.ripard@bootlin.com> wrote:
>
> On Fri, Apr 05, 2019 at 02:24:42PM +0200, Clément Péron wrote:
> > OrangePi One Plus and OrangePi Lite2 use the same PIO regulators.
> >
> > Add this in the common device tree.
> >
> > Signed-off-by: Clément Péron <peron.clem@gmail.com>
> > ---
> > arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi | 11 +++++++++++
> > 1 file changed, 11 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi
> > index b2526dac2fcf..fd2af5095425 100644
> > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi
> > @@ -72,6 +72,12 @@
> > status = "okay";
> > };
> >
> > +&pio {
> > + vcc-pc-supply = <&reg_bldo2>;
> > + vcc-pd-supply = <&reg_cldo1>;
> > + vcc-pg-supply = <&reg_bldo3>;
> > +};
> > +
> > &r_i2c {
> > status = "okay";
> >
> > @@ -191,6 +197,11 @@
> > };
> > };
> >
> > +&r_pio {
> > + vcc-pl-supply = <&reg_aldo1>;
> > + vcc-pm-supply = <&reg_bldo3>;
> > +};
> > +
>
> How was this tested?
Sorry maybe I should mention that but I don't own an OrangePi or a Pine H64.

But this should have the same issue than the Beelink GS1.

>
> Please run checkpatch on your patches as well.
Thanks for the advice,
Clement

>
> Maxime
>
> --
> Maxime Ripard, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com

\
 
 \ /
  Last update: 2019-04-05 18:42    [W:0.064 / U:4.172 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site