lkml.org 
[lkml]   [2019]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH net-next] rxrpc: Mark expected switch fall-through
Date
Gustavo A. R. Silva <gustavo@embeddedor.com> wrote:

> /* Fall through and set IPv4 options too otherwise we don't get
> * errors from IPv4 packets sent through the IPv6 socket.
> */
> -
> + /* Fall through */

Er, no. Please (a) don't remove the blank line that's providing visual
separation and (b) observe that the previous comment already says "Fall
through" right at the beginning, so NAK.

If the compiler doesn't recognise this, then fix the compiler please.

David

\
 
 \ /
  Last update: 2019-04-05 17:16    [W:0.052 / U:1.428 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site