Messages in this thread |  | | Subject | Re: [PATCH v3 1/9] soc: qcom: rpmpd: fixup rpmpd set performance state | From | Marc Gonzalez <> | Date | Fri, 5 Apr 2019 16:59:10 +0200 |
| |
On 27/03/2019 13:38, Sibi Sankar wrote:
> Remoteproc q6v5-mss does set_performace_state with INT_MAX on
Remoteproc q6v5-mss calls set_performance_state()
> rpmpd. This is currently ignored since it is greater than the > max supported state. Fixup rpmpd state to max if the required > state is greater than all the supported states. > > Fixes: 075d3db8d10d ("Add support for the .set_performace_state() and > .opp_to_performance_state()") > > Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
AFAIU, the Fixes tag should be on a single line, and quote the commit subject. (And no blank line between Fixes and Signed-off-by tags.)
Fixes: 075d3db8d10d ("soc: qcom: rpmpd: Add support for get/set performance state")
> --- > drivers/soc/qcom/rpmpd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soc/qcom/rpmpd.c b/drivers/soc/qcom/rpmpd.c > index 005326050c23..235d01870dd8 100644 > --- a/drivers/soc/qcom/rpmpd.c > +++ b/drivers/soc/qcom/rpmpd.c > @@ -226,7 +226,7 @@ static int rpmpd_set_performance(struct generic_pm_domain *domain, > struct rpmpd *pd = domain_to_rpmpd(domain); > > if (state > MAX_RPMPD_STATE) > - goto out; > + state = MAX_RPMPD_STATE; > > mutex_lock(&rpmpd_lock); >
With these two nits taken care of:
Reviewed-by: Marc Gonzalez <marc.w.gonzalez@free.fr>
Regards.
|  |