Messages in this thread | | | Date | Fri, 5 Apr 2019 17:50:09 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH v2] gpio: merrifield: Fix build err without CONFIG_ACPI |
| |
On Fri, Apr 05, 2019 at 10:21:12PM +0800, Yue Haibing wrote: > From: YueHaibing <yuehaibing@huawei.com> > > When building CONFIG_ACPI is not set > gcc warn this: > > drivers/gpio/gpio-merrifield.c: In function mrfld_gpio_get_pinctrl_dev_name: > drivers/gpio/gpio-merrifield.c:388:19: error: dereferencing pointer to incomplete type struct acpi_device > put_device(&adev->dev); > ^ > Reported-by: Hulk Robot <hulkci@huawei.com> > Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Fixes:d00d2109c367 ("gpio: merrifield: Convert to use acpi_dev_get_first_match_dev()") > Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Thank you for an update, I have a comment below, but before sending v3, let Rafael to have a chance to look at it.
> #ifdef CONFIG_ACPI > extern int acpi_platform_notify(struct device *dev, enum kobject_action action); > + > +static inline void put_acpi_device(struct acpi_device *adev) > +{ > + put_device(&adev->dev); > +}
This should probably go to acpi_bus.h under acpi_dev_get_first_match_dev(). And talking to Mika we agreed that naming would be better as acpi_dev_put().
-- With Best Regards, Andy Shevchenko
| |