lkml.org 
[lkml]   [2019]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v7 4/7] sched/core: Prevent race condition between cpuset and __sched_setscheduler()
On Wed, Apr 03, 2019 at 10:46:47AM +0200, Juri Lelli wrote:
> +static inline void cpuset_read_only_lock(unsigned long *flags)
> +{
> + local_irq_save(*flags);
> + preempt_disable();
> +}
> +
> +static inline void cpuset_read_only_unlock(unsigned long *flags)
> +{
> + local_irq_restore(*flags);
> + preempt_enable();
> +}

You can ditch the preempt stuff. IRQs disabled already very much implies
!preemptible.

\
 
 \ /
  Last update: 2019-04-05 14:39    [W:0.061 / U:0.024 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site