lkml.org 
[lkml]   [2019]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: rtl8192u: ieee80211: add space around '==' and before '('
On Fri, Apr 05, 2019 at 10:31:17AM +0800, YueHaibing wrote:
> On 2019/4/5 9:56, Caio Salvador Rohwedder wrote:
> > if(!list_empty(pUnusedList)) {
> > (*ppTS) = list_entry(pUnusedList->next, struct ts_common_info, list);
> > list_del_init(&(*ppTS)->list);
> > - if(TxRxSelect==TX_DIR) {
> > + if (TxRxSelect == TX_DIR) {
> > struct tx_ts_record *tmp = container_of(*ppTS, struct tx_ts_record, ts_common_info);
>
> This line seems over 80 characters, may also be fixed.
>

The 80 character problem isn't really related to the "space required"
problem. Those would need to be fixed in separate patches.

> In fact, this file has so many code style issues, see
>
> ./scripts/checkpatch.pl --no-tree -f drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c
>

Yes. Of course it has millions of style issues. It's staging code.
Leave it. We'll fix it little by little.

That said, I kind of would prefer to review patches which fix all the
"space[s] required" checkpatch warnings in a file in one go...

regards,
dan carpenter

\
 
 \ /
  Last update: 2019-04-05 07:12    [W:0.037 / U:6.812 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site