Messages in this thread | | | Date | Thu, 4 Apr 2019 12:12:06 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH] staging: iio: cdc: ad7746: Replace bitshift by BIT |
| |
On Wed, Apr 03, 2019 at 05:45:02PM -0300, Lucas Oshiro wrote: > #define AD7746_VTSETUP_VTMD_INT_TEMP (0 << 5) > -#define AD7746_VTSETUP_VTMD_EXT_TEMP (1 << 5) > +#define AD7746_VTSETUP_VTMD_EXT_TEMP BIT(5)
No, the original is more readable. Otherwise you can't see that it's part of a set.
Just ignore checkpatch when it gives nonsense advice.
regards, dan carpenter
| |