lkml.org 
[lkml]   [2019]   [Apr]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.0 131/246] tools build: Add -lrt to FEATURE_CHECK_LDFLAGS-libaio
    Date
    5.0-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    [ Upstream commit aa8f9c517ebce7a0959da064ef2660ea03f133f8 ]

    Since we need it to resolve the AIO symbols, otherwise we fail with:

    $ cat /tmp/build/perf/feature/test-all.make.output
    /usr/bin/ld: /tmp/ccEqrj36.o: undefined reference to symbol 'aio_return64@@GLIBC_2.2.5'
    /usr/bin/ld: //usr/lib64/librt.so.1: error adding symbols: DSO missing from command line
    collect2: error: ld returned 1 exit status
    $

    When we added the aio support in 'perf record' only the test-libaio.bin
    target got the -lrt, i.e. the feature detection slow path. Fix it.

    Cc: Adrian Hunter <adrian.hunter@intel.com>
    Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
    Cc: Alexey Budankov <alexey.budankov@linux.intel.com>
    Cc: Andi Kleen <ak@linux.intel.com>
    Cc: Jiri Olsa <jolsa@kernel.org>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Fixes: 2a07d814747b ("tools build feature: Check if libaio is available")
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    tools/perf/Makefile.config | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config
    index b441c88cafa1..e6360d47e73a 100644
    --- a/tools/perf/Makefile.config
    +++ b/tools/perf/Makefile.config
    @@ -218,6 +218,8 @@ FEATURE_CHECK_LDFLAGS-libpython := $(PYTHON_EMBED_LDOPTS)
    FEATURE_CHECK_CFLAGS-libpython-version := $(PYTHON_EMBED_CCOPTS)
    FEATURE_CHECK_LDFLAGS-libpython-version := $(PYTHON_EMBED_LDOPTS)

    +FEATURE_CHECK_LDFLAGS-libaio = -lrt
    +
    CFLAGS += -fno-omit-frame-pointer
    CFLAGS += -ggdb3
    CFLAGS += -funwind-tables
    --
    2.19.1


    \
     
     \ /
      Last update: 2019-04-04 11:25    [W:4.176 / U:0.432 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site