[lkml]   [2019]   [Apr]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v3 00/25] Add generic support for composing LED class device name
Hi Pavel,

On 4/4/19 3:21 PM, Pavel Machek wrote:
> Hi!
> I have not yet gone through the series in great detail.
> This will change the userland ABI, right? Now, I understand that old ABI is bad, but
> will it break someone's code?

It will not break anyone since the generic support for composing
LED names is used only if struct init_data is provided. Otherwise
led_cdev->name property is taken as is for the LED class device name.

Moreover, it is safe to switch many of existing DT (or fwnode in
general) based drivers to using generic mechanism.
If the DT provides label property it will be concatenated with the
led_hw_name provided by the driver. The problem would be only with
the drivers whose bindings erroneously require devicename section
in the label. They will need to be left intact.

Best regards,
Jacek Anaszewski

 \ /
  Last update: 2019-04-04 21:20    [W:0.166 / U:1.552 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site