Messages in this thread | | | Subject | Re: [PATCH] drm/panel: Rocktech jh057n00900: Add terminating newlines to logging | From | Joe Perches <> | Date | Thu, 04 Apr 2019 11:55:17 -0700 |
| |
On Thu, 2019-04-04 at 19:00 +0200, Sam Ravnborg wrote: > Hi Joe. > > On Thu, Apr 04, 2019 at 08:06:09AM -0700, Joe Perches wrote: > > These were missing '\n' terminations, add them. > > > > Signed-off-by: Joe Perches <joe@perches.com> > > --- > > drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c | 19 ++++++++++--------- > > 1 file changed, 10 insertions(+), 9 deletions(-) > > > > diff --git a/drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c b/drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c > > index 158a6d548068..d88ea8da2ec2 100644 > > --- a/drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c > > +++ b/drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c > > @@ -123,7 +123,7 @@ static int jh057n_init_sequence(struct jh057n *ctx) > > > > ret = mipi_dsi_dcs_exit_sleep_mode(dsi); > > if (ret < 0) { > > - DRM_DEV_ERROR(dev, "Failed to exit sleep mode"); > > + DRM_DEV_ERROR(dev, "Failed to exit sleep mode\n"); > > I was under the impression that newlines was optional these days. > Should we always use them with logging?
Yes.
The general problem is KERN_CONT/pr_cont uses where interleaving is still possible from multiple threads.
> I did not find any obvious clues in linux/printk.h
I'll see about adding something one day to the Documentation. Likely in coding-style.rst.
| |