Messages in this thread | | | Date | Thu, 4 Apr 2019 14:24:25 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH v3] x86/boot: Use efi_setup_data for searching RSDP on kexec-ed kernel |
| |
On Thu, Apr 04, 2019 at 03:32:33PM +0800, Dave Young wrote: > BTW, it would be good to start a new thread when you send V4 :)
Yes please.
> > + /* Get systab from boot params. */ > > + systab = (efi_system_table_64_t *) (ei->efi_systab | ((__u64)ei->efi_systab_hi << 32)); > > + if (!systab) > > + error("EFI system table not found in kexec boot_params."); > > Instead of hang the system, return 0 should be better
Can the kexec kernel even function if we fail here?
-- Regards/Gruss, Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
| |