lkml.org 
[lkml]   [2019]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] io_uring: free allocated io_memory once
On Tue, Apr 30, 2019 at 10:22:23AM -0600, Jens Axboe wrote:
> On 4/30/19 10:20 AM, Mark Rutland wrote:
> > - io_mem_free(ctx->sq_ring);
> > - io_mem_free(ctx->sq_sqes);
> > - io_mem_free(ctx->cq_ring);
> > + if (ctx->sq_ring)
> > + io_mem_free(ctx->sq_ring);
> > + if (ctx->sq_sqes)
> > + io_mem_free(ctx->sq_sqes);
> > + if (ctx->cq_ring)
> > + io_mem_free(ctx->cq_ring);
>
> Please just make io_mem_free() handle a NULL pointer so we don't need
> these checks.

Sure; I'll spin a v2 momentarily.

Thanks,
Mark.

\
 
 \ /
  Last update: 2019-04-30 18:27    [W:0.031 / U:0.536 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site