Messages in this thread | | | Date | Tue, 30 Apr 2019 16:03:39 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH V2] staging: fieldbus: anybus-s: force endiannes annotation |
| |
On Tue, Apr 30, 2019 at 09:32:20AM -0400, Sven Van Asbroeck wrote: > On Tue, Apr 30, 2019 at 12:19 AM Al Viro <viro@zeniv.linux.org.uk> wrote: > > > > ... not that there's much sense keeping ->fieldbus_type in host-endian, > > while we are at it. > > Interesting! Suppose we make device->fieldbus_type bus-endian.
Keep it bus-endian, as that's the "normal" way bus structures work (like PCI and USB for example), and that should be in a documented, and consistent, form, right?
Then do the conversion when you access the field from within the kernel. Again, examples of USB and PCI can be used if you want to copy what they do.
thanks,
greg k-h
| |