lkml.org 
[lkml]   [2019]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 25/41] netfilter: ebtables: CONFIG_COMPAT: drop a bogus WARN_ON
    Date
    From: Florian Westphal <fw@strlen.de>

    commit 7caa56f006e9d712b44f27b32520c66420d5cbc6 upstream.

    It means userspace gave us a ruleset where there is some other
    data after the ebtables target but before the beginning of the next rule.

    Fixes: 81e675c227ec ("netfilter: ebtables: add CONFIG_COMPAT support")
    Reported-by: syzbot+659574e7bcc7f7eb4df7@syzkaller.appspotmail.com
    Signed-off-by: Florian Westphal <fw@strlen.de>
    Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    net/bridge/netfilter/ebtables.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    --- a/net/bridge/netfilter/ebtables.c
    +++ b/net/bridge/netfilter/ebtables.c
    @@ -2056,7 +2056,8 @@ static int ebt_size_mwt(struct compat_eb
    if (match_kern)
    match_kern->match_size = ret;

    - if (WARN_ON(type == EBT_COMPAT_TARGET && size_left))
    + /* rule should have no remaining data after target */
    + if (type == EBT_COMPAT_TARGET && size_left)
    return -EINVAL;

    match32 = (struct compat_ebt_entry_mwt *) buf;

    \
     
     \ /
      Last update: 2019-04-30 14:07    [W:6.752 / U:0.124 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site