lkml.org 
[lkml]   [2019]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [tip:sched/urgent] sched/cpufreq: Fix kobject memleak
On Tue, Apr 30, 2019 at 11:26:27AM +0530, Viresh Kumar wrote:
> On 29-04-19, 22:52, tip-bot for Tobin C. Harding wrote:
> > Commit-ID: 8bf7ab9c79f3d1a5f02ebac369f656de9ec0aca8
> > Gitweb: https://git.kernel.org/tip/8bf7ab9c79f3d1a5f02ebac369f656de9ec0aca8
> > Author: Tobin C. Harding <tobin@kernel.org>
> > AuthorDate: Tue, 30 Apr 2019 10:11:44 +1000
> > Committer: Ingo Molnar <mingo@kernel.org>
> > CommitDate: Tue, 30 Apr 2019 06:24:09 +0200
> >
> > sched/cpufreq: Fix kobject memleak
> >
> > Currently the error return path from kobject_init_and_add() is not
> > followed by a call to kobject_put() - which means we are leaking
> > the kobject.
> >
> > Fix it by adding a call to kobject_put() in the error path of
> > kobject_init_and_add().
> >
> > Signed-off-by: Tobin C. Harding <tobin@kernel.org>
> > Add call to kobject_put() in error path of kobject_init_and_add().
>
> This should have been present before the signed-off ?

Thanks. Some face palm fails on this patch. Its hard to get good help
:)

Tobin

\
 
 \ /
  Last update: 2019-04-30 08:28    [W:0.033 / U:1.424 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site