lkml.org 
[lkml]   [2019]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 023/100] cifs: fix memory leak in SMB2_read
    Date
    From: Ronnie Sahlberg <lsahlber@redhat.com>

    commit 05fd5c2c61732152a6bddc318aae62d7e436629b upstream.

    Commit 088aaf17aa79300cab14dbee2569c58cfafd7d6e introduced a leak where
    if SMB2_read() returned an error we would return without freeing the
    request buffer.

    Cc: Stable <stable@vger.kernel.org>
    Signed-off-by: Ronnie Sahlberg <lsahlber@redhat.com>
    Reviewed-by: Pavel Shilovsky <pshilov@microsoft.com>
    Signed-off-by: Steve French <stfrench@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    fs/cifs/smb2pdu.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/fs/cifs/smb2pdu.c
    +++ b/fs/cifs/smb2pdu.c
    @@ -3285,6 +3285,7 @@ SMB2_read(const unsigned int xid, struct
    rc);
    }
    free_rsp_buf(resp_buftype, rsp_iov.iov_base);
    + cifs_small_buf_release(req);
    return rc == -ENODATA ? 0 : rc;
    } else
    trace_smb3_read_done(xid, req->PersistentFileId,

    \
     
     \ /
      Last update: 2019-04-30 14:02    [W:2.675 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site