lkml.org 
[lkml]   [2019]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.0 23/89] RDMA/mlx5: Do not allow the user to write to the clock page
    Date
    From: Jason Gunthorpe <jgg@mellanox.com>

    commit c660133c339f9ab684fdf568c0d51b9ae5e86002 upstream.

    The intent of this VMA was to be read-only from user space, but the
    VM_MAYWRITE masking was missed, so mprotect could make it writable.

    Cc: stable@vger.kernel.org
    Fixes: 5c99eaecb1fc ("IB/mlx5: Mmap the HCA's clock info to user-space")
    Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
    Reviewed-by: Haggai Eran <haggaie@mellanox.com>
    Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/infiniband/hw/mlx5/main.c | 2 ++
    1 file changed, 2 insertions(+)

    --- a/drivers/infiniband/hw/mlx5/main.c
    +++ b/drivers/infiniband/hw/mlx5/main.c
    @@ -1982,6 +1982,7 @@ static int mlx5_ib_mmap_clock_info_page(

    if (vma->vm_flags & VM_WRITE)
    return -EPERM;
    + vma->vm_flags &= ~VM_MAYWRITE;

    if (!dev->mdev->clock_info_page)
    return -EOPNOTSUPP;
    @@ -2147,6 +2148,7 @@ static int mlx5_ib_mmap(struct ib_uconte

    if (vma->vm_flags & VM_WRITE)
    return -EPERM;
    + vma->vm_flags &= ~VM_MAYWRITE;

    /* Don't expose to user-space information it shouldn't have */
    if (PAGE_SIZE > 4096)

    \
     
     \ /
      Last update: 2019-04-30 13:57    [W:4.282 / U:1.392 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site