lkml.org 
[lkml]   [2019]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 3/3] prctl_set_mm: downgrade mmap_sem to read lock
From
Date
On 30.04.2019 12:08, Cyrill Gorcunov wrote:
> On Tue, Apr 30, 2019 at 11:55:45AM +0300, Kirill Tkhai wrote:
>>> - up_write(&mm->mmap_sem);
>>> + spin_unlock(&mm->arg_lock);
>>> + up_read(&mm->mmap_sem);
>>> return error;
>>
>> Hm, shouldn't spin_lock()/spin_unlock() pair go as a fixup to existing code
>> in a separate patch?
>>
>> Without them, the existing code has a problem at least in get_mm_cmdline().
>
> Seems reasonable to merge it into patch 1.

Sounds sensibly.

\
 
 \ /
  Last update: 2019-04-30 11:12    [W:0.082 / U:0.672 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site