lkml.org 
[lkml]   [2019]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 1/4] include: dt-bindings: add Performance Monitoring Unit for Exynos
From
Date


On 4/30/19 6:56 AM, Chanwoo Choi wrote:
> Hi,
>
> I agree of this patch. But, I add the minor comments.
>
> If you edit them according to my comment, feel free to add my following tag:
> Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
>
> On 19. 4. 19. 오후 10:48, Lukasz Luba wrote:
>> This patch add support of a new feature which can be used in DT:
>> Performance Monitoring Unit with defined event data type.
>> In this patch the event data types are defined for Exynos PPMU.
>> The patch also updates the MAINTAINERS file accordingly and
>> adds the header file to devfreq event subsystem.
>>
>> Signed-off-by: Lukasz Luba <l.luba@partner.samsung.com>
>> ---
>> MAINTAINERS | 1 +
>> include/dt-bindings/pmu/exynos_ppmu.h | 26 ++++++++++++++++++++++++++
>> 2 files changed, 27 insertions(+)
>> create mode 100644 include/dt-bindings/pmu/exynos_ppmu.h
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 3671fde..1ba4b9b 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -4560,6 +4560,7 @@ T: git git://git.kernel.org/pub/scm/linux/kernel/git/mzx/devfreq.git
>> S: Supported
>> F: drivers/devfreq/event/
>> F: drivers/devfreq/devfreq-event.c
>> +F: include/dt-bindings/pmu/exynos_ppmu.h
>> F: include/linux/devfreq-event.h
>> F: Documentation/devicetree/bindings/devfreq/event/
>>
>> diff --git a/include/dt-bindings/pmu/exynos_ppmu.h b/include/dt-bindings/pmu/exynos_ppmu.h
>> new file mode 100644
>> index 0000000..08fdce9
>> --- /dev/null
>> +++ b/include/dt-bindings/pmu/exynos_ppmu.h
>> @@ -0,0 +1,26 @@
>> +/* SPDX-License-Identifier: GPL-2.0 */
>> +/*
>> + * Samsung Exynos PPMU event types for counting in regs
>> + *
>> + * Copyright (c) 2019, Samsung
>
> Mabye, "Samsung Electronics" instead of 'Samsung'.
ACK
>
>> + * Author: Lukasz Luba <l.luba@partner.samsung.com>
>> + */
>> +
>> +#ifndef __DT_BINDINGS_PMU_EXYNOS_PPMU_H
>> +#define __DT_BINDINGS_PMU_EXYNOS_PPMU_H
>> +
>> +
>
> Remove unneeded blank line.
OK done. I will add your 'Acked-by' in the next version.

Regards,
Lukasz

\
 
 \ /
  Last update: 2019-04-30 22:37    [W:0.073 / U:6.076 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site