Messages in this thread | | | Date | Tue, 30 Apr 2019 21:10:21 +0200 | From | Alexandre Belloni <> | Subject | Re: [PATCH 2/4] rtc: digicolor: set range |
| |
On 30/04/2019 18:25:52+0300, Baruch Siach wrote: > > Yes, this is ok to return a valid value that is higher than range_max. > > However, at that time, you will not be able to set any alarms anymore as > > the core doesn't allow to set alarms after range_max. > > > > I would think that this is fine because this will happen in 2106 and we > > have a way to offset the time (the whole goal of setting the range) > > using device tree. > > That's the sort of documentation that I'm missing. The 'start-year' > property is mentioned in the DT binding documentation. But I don't see > where range_max is documented as a facility for the time offset feature. >
Sure, I'm planning to document better how a proper RTC driver should be written. I needed to cleanup the digicolor driver because I4m removing .set_mmss and .set_mmss64 this cycle.
-- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
| |