Messages in this thread | | | From | Nick Desaulniers <> | Date | Tue, 30 Apr 2019 11:22:35 -0700 | Subject | Re: [PATCH 11/10] arm64: unbreak DYNAMIC_DEBUG=y build with clang |
| |
On Mon, Apr 29, 2019 at 10:32 AM Nick Desaulniers <ndesaulniers@google.com> wrote: > > On Fri, Apr 26, 2019 at 12:06 PM Rasmus Villemoes > <linux@rasmusvillemoes.dk> wrote: > > > > Current versions of clang does not like the %c modifier in inline > > assembly for targets other than x86, so any DYNAMIC_DEBUG=y build > > fails on arm64. A fix is likely to land in 9.0 (see > > https://github.com/ClangBuiltLinux/linux/issues/456), but unbreak the > > build for older versions. > > > > Fixes: arm64: select DYNAMIC_DEBUG_RELATIVE_POINTERS > > Reported-by: Nathan Chancellor <natechancellor@gmail.com> > > Reported-by: Arnd Bergmann <arnd@arndb.de> > > Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk> > > --- > > Andrew, please apply and/or fold into 9/10. > > > > arch/arm64/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > > index d0871d523d5d..315992e33b17 100644 > > --- a/arch/arm64/Kconfig > > +++ b/arch/arm64/Kconfig > > @@ -83,7 +83,7 @@ config ARM64 > > select CRC32 > > select DCACHE_WORD_ACCESS > > select DMA_DIRECT_REMAP > > - select DYNAMIC_DEBUG_RELATIVE_POINTERS > > + select DYNAMIC_DEBUG_RELATIVE_POINTERS if CC_IS_GCC || CLANG_VERSION >= 90000 > > I just landed the fix for this in Clang, I think around the time you > sent the patch. Should ship in Clang 9. Thanks for unbreaking our > build. > Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
+ Dan who's looking for this to get picked up to unbreak KernelCI arm64+clang builds https://staging.kernelci.org/build/id/5cc6e080cf3a0f9d66257f6d/ -- Thanks, ~Nick Desaulniers
| |