Messages in this thread | | | From | Stephen Boyd <> | Subject | Re: [PATCH] clk: imx: pllv3: Fix fall through build warning | Date | Tue, 30 Apr 2019 11:16:47 -0700 |
| |
Quoting Anson Huang (2019-04-29 18:55:18) > Fix below fall through build warning: > > drivers/clk/imx/clk-pllv3.c:453:21: warning: > this statement may fall through [-Wimplicit-fallthrough=] > > pll->denom_offset = PLL_IMX7_DENOM_OFFSET; > ^ > drivers/clk/imx/clk-pllv3.c:454:2: note: here > case IMX_PLLV3_AV: > ^~~~ > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > ---
Gustavo says there are two warnings. Please compile test with the right options, add Reported-by tags when you get bug reports from someone, and add a Fixes tag and then resend.
> drivers/clk/imx/clk-pllv3.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/clk/imx/clk-pllv3.c b/drivers/clk/imx/clk-pllv3.c > index e892b9a..fbe4fe0 100644 > --- a/drivers/clk/imx/clk-pllv3.c > +++ b/drivers/clk/imx/clk-pllv3.c > @@ -451,6 +451,7 @@ struct clk *imx_clk_pllv3(enum imx_pllv3_type type, const char *name, > case IMX_PLLV3_AV_IMX7: > pll->num_offset = PLL_IMX7_NUM_OFFSET; > pll->denom_offset = PLL_IMX7_DENOM_OFFSET; > + /* fall through */ > case IMX_PLLV3_AV: > ops = &clk_pllv3_av_ops; > break;
| |