Messages in this thread | | | Subject | Re: [PATCH] clk: imx: clk-pllv3: mark expected switch fall-throughs | From | "Gustavo A. R. Silva" <> | Date | Tue, 30 Apr 2019 12:28:32 -0500 |
| |
On 4/30/19 12:22 PM, Stephen Boyd wrote: > Quoting Gustavo A. R. Silva (2019-04-30 07:32:06) >> In preparation to enabling -Wimplicit-fallthrough, mark switch >> cases where we are expecting to fall through. >> >> This patch fixes the following warnings: >> >> drivers/clk/imx/clk-pllv3.c: In function ‘imx_clk_pllv3’: >> drivers/clk/imx/clk-pllv3.c:446:18: warning: this statement may fall through [-Wimplicit-fallthrough=] >> pll->div_shift = 1; >> ~~~~~~~~~~~~~~~^~~ >> drivers/clk/imx/clk-pllv3.c:447:2: note: here >> case IMX_PLLV3_USB: >> ^~~~ >> drivers/clk/imx/clk-pllv3.c:453:21: warning: this statement may fall through [-Wimplicit-fallthrough=] >> pll->denom_offset = PLL_IMX7_DENOM_OFFSET; >> ^ >> drivers/clk/imx/clk-pllv3.c:454:2: note: here >> case IMX_PLLV3_AV: >> ^~~~ >> >> Warning level 3 was used: -Wimplicit-fallthrough=3 >> >> This patch is part of the ongoing efforts to enable >> -Wimplicit-fallthrough. >> >> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > > It was sent by Anson already. >
Did he address both warnings?
Thanks -- Gustavo
| |