lkml.org 
[lkml]   [2019]   [Apr]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2] platform/chrome: cros_ec_spi: Transfer messages at high priority
Hi,

On Wed, Apr 3, 2019 at 11:14 AM Matthias Kaehlcke <mka@chromium.org> wrote:
> Each transfer has it's own work struct (allocated on the stack), hence
> a) does not occur. b) is still true, but shouldn't be a problem on
> its own.

Actually, it could be much worse _because_ it's on the stack. The
worker could write something back to the work after the work has been
de-allocated. That's bad.


> Anyway, using flush_work() as you suggested is the better solution :)

Yup, thanks!

\
 
 \ /
  Last update: 2019-04-03 20:18    [W:1.869 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site