Messages in this thread | | | From | Guenter Roeck <> | Date | Wed, 3 Apr 2019 09:35:00 -0700 | Subject | Re: [PATCH v2 2/2] mfd: cros_ec: Instantiate the CrOS USB PD logger driver |
| |
On Wed, Apr 3, 2019 at 7:05 AM Enric Balletbo i Serra <enric.balletbo@collabora.com> wrote: > > Add the cros-usbpd-logger driver for logging event data for the USB PD > charger available in the Embedded Controller on ChromeOS systems. The > logging feature is logically separate functionality from charge manager, > hence is instantiated as a different driver. > > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> > --- > Lee, this is send as separate patch because touches the MFD subsystem, > apart from that the driver won't be instantiated if [1/2] is not > merged, which I think is not a problem, it is safe for both go through > their subsystem separately. > > Thanks, > Enric > > Changes in v2: None > Not really. Changes in v2: Dropped unrelated whitespace changes.
Other than that,
Reviewed-by: Guenetr Roeck <linux@roeck-us.net>
> drivers/mfd/cros_ec_dev.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c > index 0638a0d82d97..3e33fa5b8657 100644 > --- a/drivers/mfd/cros_ec_dev.c > +++ b/drivers/mfd/cros_ec_dev.c > @@ -612,7 +612,8 @@ static const struct mfd_cell cros_ec_rtc_cells[] = { > }; > > static const struct mfd_cell cros_usbpd_charger_cells[] = { > - { .name = "cros-usbpd-charger" } > + { .name = "cros-usbpd-charger" }, > + { .name = "cros-usbpd-logger" }, > }; > > static const struct mfd_cell cros_ec_platform_cells[] = { > -- > 2.20.1 >
| |