lkml.org 
[lkml]   [2019]   [Apr]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 3/5] media: sunxi: Add A10 CSI driver
On Wed, Apr 03, 2019 at 11:26:55AM +0200, Maxime Ripard wrote:
> Hi Sakari,
>
> On Wed, Apr 03, 2019 at 12:12:21PM +0300, Sakari Ailus wrote:
> > Thanks for the update and my apologies for the late review.
> >
> > On Tue, Mar 19, 2019 at 04:55:46PM +0100, Maxime Ripard wrote:
> > > The older CSI drivers have camera capture interface different from the one
> > > in the newer ones.
> > >
> > > This IP is pretty simple. Some variants (one controller out of two
> > > instances on some SoCs) have an ISP embedded, but there's no code that make
> > > use of it, so we ignored that part for now.
> > >
> > > Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
> >
> > Could you add a sub-device for the CSI-2 receiver, please?
> >
> > See e.g. drivers/media/pci/intel/ipu3/ipu3-cio2.c for an example.
>
> It's confusing, I know, but this isn't a MIPI-CSI receiver. The IP is
> called CSI, but it's only capable of handling parallel and BT656.

Right, for the parallel (or Bt.656) receiver then.

--
Sakari Ailus
sakari.ailus@linux.intel.com

\
 
 \ /
  Last update: 2019-04-03 11:39    [W:0.048 / U:1.884 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site