lkml.org 
[lkml]   [2019]   [Apr]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v6 0/9] iProc I2C slave mode and NIC mode
    From
    Date
    Hi Wolfram,

    On 4/3/2019 1:44 PM, Wolfram Sang wrote:
    > On Tue, Apr 02, 2019 at 06:18:21PM -0700, Ray Jui wrote:
    >> This patch series adds the following support to the iProc I2C driver:
    >> - Increase maximum read transfer size to 255 bytes
    >> - I2C slave mode
    >> - Polling mode
    >> - NIC I2C mode
    >>
    >> This patch series is based on kernel v5.1-rc3 and available at:
    >> https://github.com/Broadcom/arm64-linux.git
    >> branch: i2c-slave-v6
    >>
    >> Changes from v5:
    >> - Address various comments from Wolfram
    >
    > In the future, please write in detail what you changed. I review so many
    > patches that I can't recall all my comments on every patch.
    >

    Sure will do next time.

    > That being said, all patches applied to for-next, thanks!
    >

    Thanks!

    > Can be fixed incrementally, my code checkers complain about:
    >
    > CPPCHECK
    > drivers/i2c/busses/i2c-bcm-iproc.c:720:14: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
    > val |= 1 << M_TX_WR_STATUS_SHIFT;
    > ^
    > drivers/i2c/busses/i2c-bcm-iproc.c:847:13: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
    > val &= ~(1 << TIM_CFG_MODE_400_SHIFT);
    > ^
    > drivers/i2c/busses/i2c-bcm-iproc.c:998:13: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
    > val &= ~(1 << TIM_CFG_MODE_400_SHIFT);
    >

    I'll submit an incremental patch to fix the above warnings. I think we
    can convert all '1 << XXX' syntax in this driver to 'BIT(XXX)'. It will
    fix all of the above warnings and make the code more readable.

    Thanks,

    Ray

    \
     
     \ /
      Last update: 2019-04-03 22:57    [W:4.806 / U:0.148 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site