Messages in this thread | | | Date | Wed, 3 Apr 2019 08:08:11 +0200 | From | Maxime Ripard <> | Subject | Re: [PATCH] watchdog: Convert to use devm_platform_ioremap_resource |
| |
On Tue, Apr 02, 2019 at 12:01:53PM -0700, Guenter Roeck wrote: > Use devm_platform_ioremap_resource to reduce source code size, > improve readability, and reduce the likelyhood of bugs. > > The conversion was done automatically with coccinelle using the > following semantic patch. > > @r@ > identifier res, pdev; > expression a; > expression index; > expression e; > @@ > > <+... > - res = platform_get_resource(pdev, IORESOURCE_MEM, index); > - a = devm_ioremap_resource(e, res); > + a = devm_platform_ioremap_resource(pdev, index); > ...+> > > @depends on r@ > identifier r.res; > @@ > - struct resource *res; > ... when != res > > @@ > identifier res, pdev; > expression index; > expression a; > @@ > - struct resource *res = platform_get_resource(pdev, IORESOURCE_MEM, index); > - a = devm_ioremap_resource(&pdev->dev, res); > + a = devm_platform_ioremap_resource(pdev, index); > > Cc: Joel Stanley <joel@jms.id.au> > Cc: Nicolas Ferre <nicolas.ferre@microchip.com> > Cc: Alexandre Belloni <alexandre.belloni@bootlin.com> > Cc: Florian Fainelli <f.fainelli@gmail.com> > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Baruch Siach <baruch@tkos.co.il> > Cc: Keguang Zhang <keguang.zhang@gmail.com> > Cc: Vladimir Zapolskiy <vz@mleia.com> > Cc: Kevin Hilman <khilman@baylibre.com> > Cc: Matthias Brugger <matthias.bgg@gmail.com> > Cc: Avi Fishman <avifishman70@gmail.com> > Cc: Nancy Yuen <yuenn@google.com> > Cc: Brendan Higgins <brendanhiggins@google.com> > Cc: Wan ZongShun <mcuos.com@gmail.com> > Cc: Michal Simek <michal.simek@xilinx.com> > Cc: Sylvain Lemieux <slemieux.tyco@gmail.com> > Cc: Kukjin Kim <kgene@kernel.org> > Cc: Barry Song <baohua@kernel.org> > Cc: Orson Zhai <orsonzhai@gmail.com> > Cc: Patrice Chotard <patrice.chotard@st.com> > Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com> > Cc: Maxime Ripard <maxime.ripard@bootlin.com>
For sunxi_wdt
Acked-by: Maxime Ripard <maxime.ripard@bootlin.com>
Thanks! Maxime
-- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com [unhandled content-type:application/pgp-signature] | |