lkml.org 
[lkml]   [2019]   [Apr]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 04/12] spi: gpio: Simplify SPI_MASTER_NO_TX check in spi_gpio_probe()
    Date
    Swap branches of the if statement in order to simplify it's logical
    condition being checked. No functional change intended.

    Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
    Cc: Mark Brown <broonie@kernel.org>
    Cc: Chris Healy <cphealy@gmail.com>
    Cc: linux-spi@vger.kernel.org
    Cc: linux-kernel@vger.kernel.org
    ---
    drivers/spi/spi-gpio.c | 12 ++++++------
    1 file changed, 6 insertions(+), 6 deletions(-)

    diff --git a/drivers/spi/spi-gpio.c b/drivers/spi/spi-gpio.c
    index ca97b861c625..137f47e271dc 100644
    --- a/drivers/spi/spi-gpio.c
    +++ b/drivers/spi/spi-gpio.c
    @@ -440,16 +440,16 @@ static int spi_gpio_probe(struct platform_device *pdev)
    bb->chipselect = spi_gpio_chipselect;
    bb->set_line_direction = spi_gpio_set_direction;

    - if ((master_flags & SPI_MASTER_NO_TX) == 0) {
    - bb->txrx_word[SPI_MODE_0] = spi_gpio_txrx_word_mode0;
    - bb->txrx_word[SPI_MODE_1] = spi_gpio_txrx_word_mode1;
    - bb->txrx_word[SPI_MODE_2] = spi_gpio_txrx_word_mode2;
    - bb->txrx_word[SPI_MODE_3] = spi_gpio_txrx_word_mode3;
    - } else {
    + if (master_flags & SPI_MASTER_NO_TX) {
    bb->txrx_word[SPI_MODE_0] = spi_gpio_spec_txrx_word_mode0;
    bb->txrx_word[SPI_MODE_1] = spi_gpio_spec_txrx_word_mode1;
    bb->txrx_word[SPI_MODE_2] = spi_gpio_spec_txrx_word_mode2;
    bb->txrx_word[SPI_MODE_3] = spi_gpio_spec_txrx_word_mode3;
    + } else {
    + bb->txrx_word[SPI_MODE_0] = spi_gpio_txrx_word_mode0;
    + bb->txrx_word[SPI_MODE_1] = spi_gpio_txrx_word_mode1;
    + bb->txrx_word[SPI_MODE_2] = spi_gpio_txrx_word_mode2;
    + bb->txrx_word[SPI_MODE_3] = spi_gpio_txrx_word_mode3;
    }
    bb->setup_transfer = spi_bitbang_setup_transfer;

    --
    2.20.1
    \
     
     \ /
      Last update: 2019-04-03 06:03    [W:4.884 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site