Messages in this thread | | | Date | Mon, 29 Apr 2019 14:05:41 -0600 | From | Raul Rangel <> | Subject | Re: [PATCH v2] xhci: Convert xhci_handshake() to use readl_poll_timeout_atomic() |
| |
On Thu, Feb 07, 2019 at 05:48:16PM -0800, Andrey Smirnov wrote: > Xhci_handshake() implements the algorithm already captured by > readl_poll_timeout_atomic(). Convert the former to use the latter to > avoid repetition. > > Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com> Tested-by: Raul E Rangel <rrangel@chromium.org> Reviewed-by: Raul E Rangel <rrangel@chromium.org>
This fixes a bug on the AMD Stoneyridge platform. usleep(1) sometimes takes over 10ms. This means a 5 second timeout can easily take over 15 seconds which will trigger the watchdog and reboot the system.
Thanks for the patch.
| |