Messages in this thread | | | Subject | Re: [GIT PULL] Please pull rdma.git | From | Doug Ledford <> | Date | Mon, 29 Apr 2019 13:13:01 -0400 |
| |
On Mon, 2019-04-29 at 09:48 -0700, Linus Torvalds wrote: > On Mon, Apr 29, 2019 at 9:29 AM Doug Ledford <dledford@redhat.com> wrote: > > > > drivers/infiniband/core/uverbs_main.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > This trivial one-liner is actually incorrect. > > It should use 'vmf->address', because the point of the ZERO_PAGE > argument is to pick the page with the right virtual address alias for > broken architectures that need those kinds. > > I'm actually surprised s390 wants it, usually it's just MIPS that has > the horribly broken virtual address translation stuff. But it looks > like for s390 it's at least only a performance issue (ie it causes > some aliases in L1 that cause cacheline ping-pong rather than anything > else).
That's what I get for listening to Jason ;-)
Well, since you have just essentially re-written the patch to be correct, you are now the developer of origin. Do you want to commit the fix directly or shall I respin it for you to pull?
-- Doug Ledford <dledford@redhat.com> GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD [unhandled content-type:application/pgp-signature] | |