Messages in this thread | | | Date | Mon, 29 Apr 2019 18:06:04 +0200 | From | Oleg Nesterov <> | Subject | Re: [PATCH 1/1] rcu/sync: simplify the state machine |
| |
On 04/28, Paul E. McKenney wrote: > > And it still looks good after review, so I have pushed it.
Thanks!
> I did add > READ_ONCE() and WRITE_ONCE() to unprotected uses of ->gp_state, but > please let me know if I messed anything up.
Well, at least WRITE_ONCE()'s look certainly unneeded to me, gp_state is protected by rss_lock.
WARN_ON_ONCE(gp_state) can read gp_state lockless, but even in this case I do not understand what READ_ONCE() tries to prevent...
Nevermind, this won't hurt and as I already said I don't understand the _ONCE() magic anyway ;)
Thanks,
Oleg.
| |