lkml.org 
[lkml]   [2019]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] rcu/sync: simplify the state machine
On 04/28, Paul E. McKenney wrote:
>
> And it still looks good after review, so I have pushed it.

Thanks!

> I did add
> READ_ONCE() and WRITE_ONCE() to unprotected uses of ->gp_state, but
> please let me know if I messed anything up.

Well, at least WRITE_ONCE()'s look certainly unneeded to me, gp_state
is protected by rss_lock.

WARN_ON_ONCE(gp_state) can read gp_state lockless, but even in this case
I do not understand what READ_ONCE() tries to prevent...

Nevermind, this won't hurt and as I already said I don't understand the
_ONCE() magic anyway ;)

Thanks,

Oleg.

\
 
 \ /
  Last update: 2019-04-29 18:06    [W:0.086 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site