lkml.org 
[lkml]   [2019]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH 1/4] fdomain: Resurrect driver (core)
On Sun, Apr 28, 2019 at 09:52:31PM +0200, Ondrej Zary wrote:
> On Wednesday 24 April 2019 08:02:12 Christoph Hellwig wrote:
> > > +static void fdomain_work(struct work_struct *work)
> > > +{
> > > + struct fdomain *fd = container_of(work, struct fdomain, work);
> > > + struct Scsi_Host *sh = container_of((void *)fd, struct Scsi_Host,
> > > + hostdata);
> >
> > This looks odd. We should never need a void cast for container_of.
>
> This cast is present in all drivers involving container_of, struct Scsi_Host and hostdata. hostdata in struct Scsi_Host is defined as "unsigned long hostdata[0]"...

Oh, right - it is the hostdata mess. Sorry for the noise!

\
 
 \ /
  Last update: 2019-04-29 13:52    [W:0.042 / U:3.532 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site