Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: [PATCH v3] gpio: merrifield: Fix build err without CONFIG_ACPI | Date | Mon, 29 Apr 2019 10:40:37 +0200 |
| |
On Friday, April 26, 2019 2:23:17 PM CEST Andy Shevchenko wrote: > On Tue, Apr 23, 2019 at 11:17:32AM +0200, Linus Walleij wrote: > > On Fri, Apr 12, 2019 at 5:20 PM Yue Haibing <yuehaibing@huawei.com> wrote: > > > > > From: YueHaibing <yuehaibing@huawei.com> > > > > > > When building CONFIG_ACPI is not set > > > gcc warn this: > > > > > > drivers/gpio/gpio-merrifield.c: In function mrfld_gpio_get_pinctrl_dev_name: > > > drivers/gpio/gpio-merrifield.c:388:19: error: dereferencing pointer to incomplete type struct acpi_device > > > put_device(&adev->dev); > > > ^~ > > > > > > Reported-by: Hulk Robot <hulkci@huawei.com> > > > Fixes:d00d2109c367 ("gpio: merrifield: Convert to use acpi_dev_get_first_match_dev()") > > > Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > > > > This doesn't apply cleanly to any GPIO branch (devel or fixes) > > so I assume it is supposed to be applied to the ACPI tree. > > Acked-by: Linus Walleij <linus.walleij@linaro.org> > > Thanks! > Rafael, can this be applied to your tree?
Done already, thanks!
| |