Messages in this thread | | | From | Linus Torvalds <> | Date | Sun, 28 Apr 2019 15:46:07 -0700 | Subject | Re: [PATCH-tip v7 00/20] locking/rwsem: Rwsem rearchitecture part 2 |
| |
This doesn't seem to be the full diff - looking at that patch 1 you seem to have taken my suggested list_cut_before() change too.
I'm not against it (it does seem to be simpler and better), I just hope you double-checked it, since I kind of hand-waved it.
Linus
On Sun, Apr 28, 2019 at 2:26 PM Waiman Long <longman@redhat.com> wrote: > > v6=>v7 diff > ----------- > diff --git a/kernel/locking/rwsem.c b/kernel/locking/rwsem.c > index 97a2334d9cd3..60783267b50d 100644 > --- a/kernel/locking/rwsem.c > +++ b/kernel/locking/rwsem.c > @@ -693,7 +693,7 @@ static void __rwsem_mark_wake(struct rw_semaphore *sem, > atomic_long_add(adjustment, &sem->count); > > /* 2nd pass */ > - list_for_each_entry(waiter, &wlist, list) { > + list_for_each_entry_safe(waiter, tmp, &wlist, list) { > struct task_struct *tsk; > > tsk = waiter->task; >
| |