lkml.org 
[lkml]   [2019]   [Apr]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 031/202] CIFS: Do not hide EINTR after sending network packets
    3.16.66-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Pavel Shilovsky <pshilov@microsoft.com>

    commit ee13919c2e8d1f904e035ad4b4239029a8994131 upstream.

    Currently we hide EINTR code returned from sock_sendmsg()
    and return 0 instead. This makes a caller think that we
    successfully completed the network operation which is not
    true. Fix this by properly returning EINTR to callers.

    Signed-off-by: Pavel Shilovsky <pshilov@microsoft.com>
    Reviewed-by: Jeff Layton <jlayton@kernel.org>
    Signed-off-by: Steve French <stfrench@microsoft.com>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    fs/cifs/transport.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/fs/cifs/transport.c
    +++ b/fs/cifs/transport.c
    @@ -376,7 +376,7 @@ uncork:
    if (rc < 0 && rc != -EINTR)
    cifs_dbg(VFS, "Error %d sending data on socket to server\n",
    rc);
    - else
    + else if (rc > 0)
    rc = 0;

    return rc;
    \
     
     \ /
      Last update: 2019-04-27 17:27    [W:4.108 / U:0.448 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site