lkml.org 
[lkml]   [2019]   [Apr]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] iio: temperature: maxim_thermocouple: declare missing of table
On Thu, 25 Apr 2019 09:35:07 +0800
Matt Ranostay <matt.ranostay@konsulko.com> wrote:

> On Wed, Apr 24, 2019 at 5:42 AM Daniel Gomez <dagmcr@gmail.com> wrote:
> >
> > Add missing <of_device_id> table for SPI driver relying on SPI
> > device match since compatible is in a DT binding or in a DTS.
> >
> > Before this patch:
> > modinfo drivers/iio/temperature/maxim_thermocouple.ko | grep alias
> > alias: spi:max31855
> > alias: spi:max6675
> >
> > After this patch:
> > modinfo drivers/iio/temperature/maxim_thermocouple.ko | grep alias
> > alias: spi:max31855
> > alias: spi:max6675
> > alias: of:N*T*Cmaxim,max31855C*
> > alias: of:N*T*Cmaxim,max31855
> > alias: of:N*T*Cmaxim,max6675C*
> > alias: of:N*T*Cmaxim,max6675
>
> Heh oops I missed that somehow in initial development.
>
> Acked-by: Matt Ranostay <matt.ranostay@konsulko.com>
Applied to the togreg branch of iio.git. Given timing this may have
to wait for the next cycle to go upstream.

Thanks.
Jonathan

>
> >
> > Reported-by: Javier Martinez Canillas <javier@dowhile0.org>
> > Signed-off-by: Daniel Gomez <dagmcr@gmail.com>
> > ---
> > drivers/iio/temperature/maxim_thermocouple.c | 10 ++++++++++
> > 1 file changed, 10 insertions(+)
> >
> > diff --git a/drivers/iio/temperature/maxim_thermocouple.c b/drivers/iio/temperature/maxim_thermocouple.c
> > index c31b963..c613a64 100644
> > --- a/drivers/iio/temperature/maxim_thermocouple.c
> > +++ b/drivers/iio/temperature/maxim_thermocouple.c
> > @@ -10,6 +10,8 @@
> > #include <linux/init.h>
> > #include <linux/mutex.h>
> > #include <linux/err.h>
> > +#include <linux/of.h>
> > +#include <linux/of_device.h>
> > #include <linux/spi/spi.h>
> > #include <linux/iio/iio.h>
> > #include <linux/iio/trigger.h>
> > @@ -262,9 +264,17 @@ static const struct spi_device_id maxim_thermocouple_id[] = {
> > };
> > MODULE_DEVICE_TABLE(spi, maxim_thermocouple_id);
> >
> > +static const struct of_device_id maxim_thermocouple_of_match[] = {
> > + { .compatible = "maxim,max6675" },
> > + { .compatible = "maxim,max31855" },
> > + { },
> > +};
> > +MODULE_DEVICE_TABLE(of, maxim_thermocouple_of_match);
> > +
> > static struct spi_driver maxim_thermocouple_driver = {
> > .driver = {
> > .name = MAXIM_THERMOCOUPLE_DRV_NAME,
> > + .of_match_table = maxim_thermocouple_of_match,
> > },
> > .probe = maxim_thermocouple_probe,
> > .remove = maxim_thermocouple_remove,
> > --
> > 2.7.4
> >

\
 
 \ /
  Last update: 2019-04-27 14:56    [W:0.142 / U:0.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site