lkml.org 
[lkml]   [2019]   [Apr]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 06/41] drivers: tty: serial: sb1250-duart: use dev_err() instead of printk()
    Date
    Using dev_err() instead of printk() for more consistent output.
    (prints device name, etc).

    Signed-off-by: Enrico Weigelt <info@metux.net>
    ---
    drivers/tty/serial/sb1250-duart.c | 5 ++---
    1 file changed, 2 insertions(+), 3 deletions(-)

    diff --git a/drivers/tty/serial/sb1250-duart.c b/drivers/tty/serial/sb1250-duart.c
    index 329aced..655961c 100644
    --- a/drivers/tty/serial/sb1250-duart.c
    +++ b/drivers/tty/serial/sb1250-duart.c
    @@ -663,7 +663,6 @@ static void sbd_release_port(struct uart_port *uport)

    static int sbd_map_port(struct uart_port *uport)
    {
    - const char *err = KERN_ERR "sbd: Cannot map MMIO\n";
    struct sbd_port *sport = to_sport(uport);
    struct sbd_duart *duart = sport->duart;

    @@ -671,7 +670,7 @@ static int sbd_map_port(struct uart_port *uport)
    uport->membase = ioremap_nocache(uport->mapbase,
    DUART_CHANREG_SPACING);
    if (!uport->membase) {
    - printk(err);
    + dev_err(uport->dev, "Cannot map MMIO (base)\n");
    return -ENOMEM;
    }

    @@ -679,7 +678,7 @@ static int sbd_map_port(struct uart_port *uport)
    sport->memctrl = ioremap_nocache(duart->mapctrl,
    DUART_CHANREG_SPACING);
    if (!sport->memctrl) {
    - printk(err);
    + dev_err(uport->dev, "Cannot map MMIO (ctrl)\n");
    iounmap(uport->membase);
    uport->membase = NULL;
    return -ENOMEM;
    --
    1.9.1
    \
     
     \ /
      Last update: 2019-04-27 14:55    [W:2.673 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site