lkml.org 
[lkml]   [2019]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC][PATCH 1/2] printk: lock console_sem before we unregister boot consoles
On (04/25/19 12:52), Sergey Senozhatsky wrote:
> > Could we remove it in this patch? It touches it indirectly anyway.
>
> Sure we can.
>
> We also can take extra care of pr_info("%sconsole [%s%d] enabled\n".
> Right now we do
>
> ...
> console_unlock();
> console_sysfs_notify();
>
> pr_info("%sconsole [%s%d] enabled\n",....
>
>
> But we can simply move that pr_info() a bit up:
>
> pr_info("%sconsole [%s%d] enabled\n",
> console_unlock();
> console_sysfs_notify();
>
>
> So the message will be printed on all consoles.

---

Petr, Steven, would you prefer to have it as two separate patches - one
removes the comment; the other one moves pr_info("console enabled") - or
as one patch? It's sort of trivial enough to be in just one patch, but
I also can submit it as separate changes.

-ss

\
 
 \ /
  Last update: 2019-04-25 08:44    [W:0.202 / U:13.624 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site