lkml.org 
[lkml]   [2019]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: linux-next: Fixes tags need some work in the hid tree
Hi Stephen,

On Thu, Apr 25, 2019 at 3:34 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> In commit
>
> 39b3c3a5fbc5 ("HID: input: fix assignment of .value")
>
> Fixes tag
>
> Fixes: 2dc702c991e377 ("HID: input: use the Resolution Multiplier for
>
> has these problem(s):
>
> - Subject has leading but no trailing parentheses
> - Subject has leading but no trailing quotes
>
> In commit
>
> d43c17ead879 ("HID: input: make sure the wheel high resolution multiplier is set")
>
> Fixes tag
>
> Fixes: 2dc702c991e377 ("HID: input: use the Resolution Multiplier for
>
> has these problem(s):
>
> - Subject has leading but no trailing parentheses
> - Subject has leading but no trailing quotes
>
> Please do not aplit Fixes tags over more than one line.
>

Sorry for that, these are my commits.

I just re-read the doc, and indeed, we are not supposed to trim or
split the commit title. I'll be more careful next time.

Also, can't we add these requirements in checkpatch?

Cheers,
Benjamin

\
 
 \ /
  Last update: 2019-04-25 16:17    [W:0.025 / U:6.500 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site