Messages in this thread | | | Date | Thu, 25 Apr 2019 12:02:59 +0200 | From | Roger Pau Monné <> | Subject | Re: [PATCH v2 2/2] xen/pvh: correctly setup the PV EFI interface for dom0 |
| |
On Wed, Apr 24, 2019 at 11:45:43AM -0400, Boris Ostrovsky wrote: > On 4/24/19 11:45 AM, Roger Pau Monné wrote: > > On Wed, Apr 24, 2019 at 11:36:41AM -0400, Boris Ostrovsky wrote: > >> On 4/23/19 9:04 AM, Roger Pau Monne wrote: > >>> This involves initializing the boot params EFI related fields and the > >>> efi global variable. > >>> > >>> Without this fix a PVH dom0 doesn't detect when booted from EFI, and > >>> thus doesn't support accessing any of the EFI related data. > >>> > >>> Reported-by: PGNet Dev <pgnet.dev@gmail.com> > >>> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com> > >> Hmm.. This seems to be breaking save/restore for me (for domU), and I > >> can't see any obvious reasons. > >> > >> Can you try it? > > Sure, thanks for the extra testing! I have to admit I haven't tested > > save/restore with this patch applied, it didn't come to mind it might > > affect that functionality. > > > > I assume it's save/restore of a PVH domU that's broken (HVM and PV are > > fine)? > > > > > PV is fine, I haven't tried HVM.
I've tested live migration and save/restore of this series on top of 5.1.0-rc5 and seems to work fine for me. On top of which Linux version where you testing, and can you paste the guest config file?
Thanks, Roger.
| |