lkml.org 
[lkml]   [2019]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC][PATCH 1/2] printk: lock console_sem before we unregister boot consoles
On (04/25/19 16:56), Sergey Senozhatsky wrote:
> > Great idea!
> >
> > It would deserve a separate patch that moves the pr_info()
> > and removes the invalid comment.
> >
> > Actually, the pr_info() would deserve a comment explaining
> > why it should be called before console_unlock().
>
> Good. So I think I'll drop patch #1 from the series, add
> two more patches - invalid comment + pr_info() - and rework
> locking in patch #3 (this should take care of a race which
> patch #1 was intended to fix).

D'oh, I can't drop patch #1, we still need to factor out
__unregister_console(). Calling unregister_console(bcon)
under console_sem will deadlock us. So I'll just end up
having __registed_console() and __unregister_console(),
both should be called under console_sem:

register_console()
{
console_lock()
__register_console()
{
...
for_each_console(bcon)
if (bcon->flags & CON_BOOT)
__unregister_console(bcon);
}
console_unlock()
}

-ss

\
 
 \ /
  Last update: 2019-04-25 11:38    [W:0.037 / U:1.840 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site