[lkml]   [2019]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] x86/paravirt: Detect oversized patching bugs as they happen and BUG_ON() to avoid later crashes
On Thu, Apr 25, 2019 at 11:17:17AM +0200, Ingo Molnar wrote:
> It basically means that we silently won't do any patching and the kernel
> will crash later on in mysterious ways, because paravirt patching is
> usually relied on.

That's OK. The compiler emits an indirect CALL/JMP to the pv_ops
structure contents. That _should_ stay valid and function correctly at
all times.

Not patching should at the very least cause a WARN with RETPOLINE
kernels though, we hard rely on the patching actually working and
writing at least a direct call.

 \ /
  Last update: 2019-04-25 11:22    [W:0.077 / U:0.644 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site