Messages in this thread | | | Date | Thu, 25 Apr 2019 11:03:43 +0530 | From | Viresh Kumar <> | Subject | Re: [PATCH] thermal/drivers/cpu_cooling: Remove pointless test in power2state() |
| |
On 24-04-19, 22:56, Daniel Lezcano wrote: > When the static power computation was removed, the test with the power > being negative was not removed. However, the substraction which was > responsible of the negative value was removed and the variable is now > an u32. A double reason to remove the test which does not make sense. > > Fixes: 84fe2cab48590 ("cpu_cooling: Drop static-power related stuff") > Cc: Viresh Kumar <viresh.kumar@linaro.org> > Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> > --- > drivers/thermal/cpu_cooling.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/thermal/cpu_cooling.c b/drivers/thermal/cpu_cooling.c > index f7c1f49ec87f..ee8419a6390c 100644 > --- a/drivers/thermal/cpu_cooling.c > +++ b/drivers/thermal/cpu_cooling.c > @@ -541,7 +541,6 @@ static int cpufreq_power2state(struct thermal_cooling_device *cdev, > struct cpufreq_cooling_device *cpufreq_cdev = cdev->devdata; > struct cpufreq_policy *policy = cpufreq_cdev->policy; > > - power = power > 0 ? power : 0; > last_load = cpufreq_cdev->last_load ?: 1; > normalised_power = (power * 100) / last_load; > target_freq = cpu_power_to_freq(cpufreq_cdev, normalised_power);
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
-- viresh
| |